feat: add worker on or off#166
Open
stepanrodimanov wants to merge 3 commits into
Open
Conversation
KonstantinKondratenko
requested review from
AndrewGavril and
KonstantinKondratenko
and removed request for
AndrewGavril
AndrewGavril
requested changes
May 15, 2026
| int64_t stats_interval = MIN_STATS_TIME; | ||
| int64_t filtering_check_interval = MIN_FILTERING_CHECK_TIME; | ||
|
|
||
| bool enable = true; |
Collaborator
There was a problem hiding this comment.
Нужно хотя бы volatle, если не защищаем переменную примитивами синхронизации. Но по-хорошему изменения всех полей класса нужно защитить потокобезопасным кодом.
| last_filtering_check_time = now; | ||
| filtering_check_interval = | ||
| MIN_FILTERING_CHECK_TIME + | ||
| (rand() % (MAX_FILTERING_CHECK_TIME - MIN_FILTERING_CHECK_TIME + 1)); |
|
|
||
| int64_t seconds_since_filtering = (now - last_filtering_check_time) / 1s; | ||
| if (seconds_since_filtering >= filtering_check_interval) { | ||
| std::thread([this]() { checkFilteringStatus(); }).detach(); |
Collaborator
There was a problem hiding this comment.
Потеряем контроль над потоком, нужно иметь возможность его убивать.
Опрос, думаю, что можем оставить, хотя я бы включил этот флаг в политику фильтрации. Мы все равно обновляем политики, так можно и этот параметр проверять.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.