Skip to content

fix(std): setClockInterval will result in negative #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nekomeowww merged 1 commit into from
Mar 8, 2026
Merged

fix(std): setClockInterval will result in negative #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions packages/std/src/set-interval/clock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,26 @@ export const setClockInterval = (func: (...args: any[]) => any, interval: number
let clockTimer: ReturnType<typeof setTimeout>

const timerId = Math.floor(Math.random() * 1e10)
// Normalize once so invalid/negative intervals don't leak into scheduling math.
const safeInterval = Number.isFinite(interval) ? Math.max(0, interval) : 0

const recurFunc = () => {
func()
const realExecuteTime = new Date().getTime()
if (!start) {
const realExecuteTime = Date.now()
if (start == null) {
start = realExecuteTime
}

tick = tick || start
tick = tick ?? start
// Drift correction: keep long-term cadence close to target interval.
const diff = realExecuteTime - tick
tick += interval
tick += safeInterval

// Since setTimeout is not accurate, we need to adjust the interval
// Clamp negative delay to avoid Node/Electron TimeoutNegativeWarning.
const nextDelay = Math.max(0, safeInterval - diff)

clockTimer = setTimeout(recurFunc, interval - diff)
clockTimer = setTimeout(recurFunc, nextDelay)
timerMap.set(timerId, clockTimer)
}

Expand Down