Make modNamespace's translatePath method null-safe #16763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Replaces NULL
$path
with empty string.Why is it needed?
The
str_replace
fn no longer quietly allows a null value to be passed to its subject param. Deprecation notices show in php logs when null is passed in php 8.1+.How to test
Future Consideration
This could also be avoided by altering the path and assets_path columns in the namespaces table to be not null with default of empty string.
Related issue(s)/PR(s)
No related issue.