-
Notifications
You must be signed in to change notification settings - Fork 311
feat: Reintroduce crowdin synchronization. #4122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IMB11
wants to merge
17
commits into
modrinth:main
Choose a base branch
from
IMB11:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After #4025 is merged, we can add it to the crowdin.yml for the moderation package. Can be done in a different PR though. |
If you manually move the existing files on Crowdin to expected locations before first running this workflow, you won't have to lose any translations and force translators to restore translations by hand from translation memory! :) That is,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of @brawaru's previous pull request before the monorepo (modrinth/knossos#1640) with the main change being it only runs on the main branch, rather than using Crowdin's branching functionality to have multiple branches of sources, which we wouldn't use anymore.
Thank you @brawaru!
Prerequisites
CROWDIN_GH_TOKEN
repository environment secret;contents: write
pull-requests: write
CROWDIN_PROJECT_ID
repository variable.CROWDIN_PERSONAL_TOKEN
repo secret..github
as needed (probably wont need any changes honestly)push
workflow should run and push the new sources to Crowdin.The first pull request made by the CI will be large as it has to populate the initial locale files with
{}
, after that it should be pretty small and review-able.