Skip to content

Conversation

Jintao-Huang
Copy link
Collaborator

No description provided.

Copy link
Contributor

Summary of Changes

Hello @Jintao-Huang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new example script for fine-tuning the Qwen3-Omni multimodal model, expanding the project's capabilities for advanced model training. Concurrently, it improves user guidance by updating documentation for the model_type parameter and refines the internal model registration process to ensure problem_type is set appropriately for sequence classification tasks. Additionally, Qwen3-VL example scripts are updated with a new environment variable for image token management.

Highlights

  • New Qwen3-Omni Example Script: A new shell script has been added to demonstrate fine-tuning the Qwen/Qwen3-Omni-30B-A3B-Instruct model, showcasing multimodal training configurations.
  • Documentation Update for model_type: The documentation for command-line parameters, specifically for model_type, has been updated in both Chinese and English to include a reference to the supported models list for clearer guidance.
  • Qwen3-VL Example Script Enhancements: The Qwen3-VL example scripts (mcore.sh and transformers.sh) now include the IMAGE_MAX_TOKEN_NUM=1024 environment variable, likely to optimize image token handling.
  • Refined problem_type Assignment Logic: The problem_type assignment in the model registration logic (swift/llm/model/register.py) has been made conditional, now only applying when the task_type is seq_cls.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new example script for fine-tuning the qwen3_omni model, updates documentation with links to supported models, and adds a configuration parameter for qwen3_vl examples. Additionally, it includes a correctness fix in swift/llm/model/register.py by ensuring that problem_type is only set for sequence classification tasks. The changes are well-implemented and improve the project's documentation, examples, and code correctness. I find no issues with the proposed changes.

@Jintao-Huang Jintao-Huang merged commit 61584b9 into modelscope:main Sep 26, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants