-
Notifications
You must be signed in to change notification settings - Fork 891
megatron swift support KTO #5971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @kevssim, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive support for Kahneman-Tversky Optimization (KTO) training within the Megatron-SWIFT framework. It includes the implementation of a dedicated KTO trainer, new command-line arguments for KTO configuration, updated documentation, and an example script to facilitate its use. The changes enable users to perform KTO-based reinforcement learning from human feedback, expanding the capabilities of the system for fine-tuning large language models. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for Kahneman-Tversky Optimization (KTO) to Megatron-SWIFT. The changes include adding a new MegatronKTOTrainer
, corresponding arguments, a utility for batching KTO data, an example script, and documentation updates. The implementation looks solid, but I have a few suggestions to improve code style consistency, robustness, and documentation clarity. Specifically, I've recommended renaming an argument to follow Python conventions, improving device handling in the loss function, and fixing minor issues in the documentation.
PR type
PR information
megatron swift support kto.