fix galore

[tastelikefeet]

PR type

• Bug Fix
• New Feature
• Document Updates
• More Models or Datasets Support

PR information

Write the detail information belongs to this PR.

Experiment results

Paste your experiment result here(if needed).

[gemini-code-assist]

Summary of Changes

Hello @tastelikefeet, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors a key utility function, get_cu_seqlens_from_position_ids, by moving it to a more central and reusable location within the swift.utils module. This change streamlines the codebase by consolidating common functionalities. Additionally, it enhances the flexibility of the GaLore optimizer by adding support for the adamw_torch_fused variant.

Highlights

• Refactoring of get_cu_seqlens_from_position_ids: The utility function get_cu_seqlens_from_position_ids has been moved from a static method within ulysses.py to a general utility module (swift/utils/torch_utils.py) and made accessible via swift.utils. This improves code organization and reusability.
• Expanded GaLore Optimizer Compatibility: The GaLore optimizer configuration now supports adamw_torch_fused, extending its compatibility with additional PyTorch optimizers.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a couple of bug fixes and refactorings. It adds support for the adamw_torch_fused optimizer in GaLore and refactors the get_cu_seqlens_from_position_ids function by moving it to a shared utility module. The changes are well-structured. My review includes a suggestion to enhance the refactored utility function to make it more robust and align with PyTorch best practices, which will improve its reusability and prevent potential issues.