feat: adding basic CSV result handling for FMI3 #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterMeisrimelModelon
requested review from
efredriksson-modelon and
hugo-sigurdson
efredriksson-modelon
approved these changes
Dec 8, 2025
Collaborator
efredriksson-modelon
left a comment
efredriksson-modelon
left a comment
There was a problem hiding this comment.
Nice 👍
One thing to note is that we have a lot similar branching/code for result handling code. At some point it would be good to investigate if we can factor out the code that sets up and get the raw data so this is not repeated for each result format .mat/.csv/..., just so we do not get 'FMI_VER x RESUTL_TYPE' number of implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping it basic here for now, leaving more data-types and/or possible re-structuring as a follow-up