Skip to content

Remove connection that was already defined in parent class. #4658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fzenith
Copy link

@fzenith fzenith commented Jun 5, 2025

There is a redundant connection in Enable1 that is already defined (identical down to annotation and indenting) in parent class Enable.
Models would still compile as the specification allows it, but OMedit reports irritating "scripting errors".

…ted a scripting error in OMedit. Code would still work, but no reason to confuse users with inconsequential error message.
@CLAassistant
Copy link

CLAassistant commented Jun 5, 2025

CLA assistant check
All committers have signed the CLA.

@AHaumer AHaumer self-assigned this Jun 5, 2025
@AHaumer AHaumer added the L: Electrical.PowerConverters Issue addresses Modelica.Electrical.PowerConverters label Jun 5, 2025
@AHaumer AHaumer added this to the MSL4.2.0 milestone Jun 5, 2025
@AHaumer AHaumer changed the title Remove connection that was already defined in parent class. It genera… Remove connection that was already defined in parent class. Jun 5, 2025
@AHaumer
Copy link
Contributor

AHaumer commented Jun 5, 2025

Modelica.Electrical.PowerConverters.Interfaces.Enable.Enable1 extends from Modelica.Electrical.PowerConverters.Interfaces.Enable.Enable
Both contain the equation connect(enableLogic.enable, enable);

Copy link
Contributor

@AHaumer AHaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO correct
Thx for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Electrical.PowerConverters Issue addresses Modelica.Electrical.PowerConverters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants