Skip to content

Improve stdio test Windows compatibility and refactor command logic #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2025
+9 −2
Merged

Improve stdio test Windows compatibility and refactor command logic #284

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60310e9
feat: Add error handling tests for InMemoryTransport
HoberMin Apr 7, 2025
a7dc125
feat: improve stdio test Windows compatibility and refactor command l…
HoberMin Apr 8, 2025
88ede37
Address review feedback: move getDefaultServerParameters to test file
felixweinberger Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/client/stdio.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,17 @@
import { JSONRPCMessage } from "../types.js";
import { StdioClientTransport, StdioServerParameters } from "./stdio.js";

const serverParameters: StdioServerParameters = {
command: "/usr/bin/tee",
// Configure default server parameters based on OS
// Uses 'more' command for Windows and 'tee' command for Unix/Linux
const getDefaultServerParameters = (): StdioServerParameters => {
if (process.platform === "win32") {
return { command: "more" };
}
return { command: "/usr/bin/tee" };
};

const serverParameters = getDefaultServerParameters();

test("should start then close cleanly", async () => {
const client = new StdioClientTransport(serverParameters);
client.onerror = (error) => {
Expand Down