-
Notifications
You must be signed in to change notification settings - Fork 358
feat(SEP-973): add support for icons and websiteUrl across relevant types #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements SEP-973 support by adding icon and website URL capabilities across the MCP Rust SDK types. It extends the existing data models to support visual representation and documentation linking for servers, resources, tools, and prompts.
Key changes:
- Adds
Icon
struct for standardized icon representation with multiple format support - Extends
Implementation
type withicons
andwebsite_url
fields for server metadata - Adds icon support to
Tool
,Resource
, andPrompt
types for individual component branding
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
crates/rmcp/src/model.rs | Introduces Icon struct and extends Implementation with icons/website_url fields |
crates/rmcp/src/model/tool.rs | Adds icons field to Tool struct |
crates/rmcp/src/model/resource.rs | Adds icons field to RawResource struct |
crates/rmcp/src/model/prompt.rs | Adds icons field to Prompt struct |
examples/servers/src/sampling_stdio.rs | Updates example to include icons field |
examples/clients/ | Updates client examples with new Implementation fields |
crates/rmcp-macros/ | Updates proc macros to support icons in tool/prompt attributes |
test files | Updates JSON schemas and test files to reflect new fields |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Motivation and Context
Implementing support for SEP-973 as requested in #417
Adds
How Has This Been Tested?
Will also
Breaking Changes
N/A
Types of changes
Checklist