Skip to content

Add basic http client support #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

jcat4
Copy link
Contributor

@jcat4 jcat4 commented May 28, 2025

Motivation and Context

Closes #3

Follow-up to #27

Happy to close the other PR and just keep this one if we want.

This adds the ability to build MCP clients with the ruby sdk. I've started with a basic HTTP client. We can add other things (i.e. streamable HTTP) later.

For simplicity, I'm just allowing custom headers to specify auth. I didn't want to build an abstraction around different auth types prematurely.

How Has This Been Tested?

The local gem build has been tested in 2 different internal repositories and is working as expected so far.

Breaking Changes

Just the stuff from #27

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@jcat4 jcat4 marked this pull request as ready for review May 29, 2025 16:22
@jcat4 jcat4 marked this pull request as draft May 29, 2025 17:54
@jcat4
Copy link
Contributor Author

jcat4 commented May 29, 2025

Decided to build in auth, going to draft to test it

@jcat4
Copy link
Contributor Author

jcat4 commented May 29, 2025

Auth is tested and working

@jcat4 jcat4 marked this pull request as ready for review May 29, 2025 19:47
@topherbullock
Copy link
Contributor

@jcat4 can you rebase on main and resolve conflicts? seems to be largely the model_context_protocol => mcp rename

@atesgoral atesgoral mentioned this pull request Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client implementation
2 participants