Skip to content

Conversation

AishwaryaKalloli
Copy link
Contributor

@AishwaryaKalloli AishwaryaKalloli commented Jun 8, 2025

Adding functionalities to client/session_group.py that are present in client/session.py.

Motivation and Context

Saw this issue where the user wants capabilities to broadcast notification to all the connected clients from a server.
Saw a similar implementation on client side at client/session_group.py. Wanted to make all the functions available here first, also helps me understand the how to implement server/session_group.py better.

If this looks good I can add the remaining functions to client session group first then create server session group.

How Has This Been Tested?

Tested through unit tests.

Breaking Changes

No.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@AishwaryaKalloli AishwaryaKalloli changed the title Added functions read_resource and resource_templates from client/session.py to client/session_group.py [wip] Added functions read_resource and resource_templates from client/session.py to client/session_group.py Jun 12, 2025
@felixweinberger felixweinberger requested a review from a team as a code owner September 17, 2025 14:56
Copy link
Contributor

@felixweinberger felixweinberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AishwaryaKalloli thanks for this contribution! And apologies for the time it took to get back to you on this PR.

Broadcasting list_changed is an interesting use case - normally I would think this is for the server implementation to manage what sessions need to be broadcast to, but I see the potential argument for making this a feature of the SDK that takes care of this for the SDK user.

Probably needs a bit of discussion among the maintainer group - I'm going to request changes for now as there will still be updates required (e.g. testing & a sync with main) but I'll report back here with feedback when I have it.

@felixweinberger felixweinberger added needs confirmation Needs confirmation that the PR is actually required or needed. needs more work Not ready to be merged yet, needs additional changes. needs more eyes Needs alignment among maintainers whether this is something we want to add labels Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs confirmation Needs confirmation that the PR is actually required or needed. needs more eyes Needs alignment among maintainers whether this is something we want to add needs more work Not ready to be merged yet, needs additional changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants