feat:if Tool Impl or else throws McpError, use its values for the RPC error #485
+148
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taobaorun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like #465 tool Impl or else throw McpError.McpStreamableServerSession should be able to throw RPC errors and McpError is the right exception for that
Motivation and Context
This PR ensures that business-level exceptions are surfaced to the client as proper JSON-RPC errors, allowing callers to receive the real cause when a Tool (or any other operation) fails.
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context