Skip to content

Go SDK: Keep audit interceptors non-blocking on errors - #36

Merged
olaservo merged 1 commit into
mainfrom
jeongukjae/go-audit-mode-nonblocking
Aug 12, 2026
Merged

Go SDK: Keep audit interceptors non-blocking on errors#36
olaservo merged 1 commit into
mainfrom
jeongukjae/go-audit-mode-nonblocking

Conversation

@jeongukjae

Copy link
Copy Markdown
Contributor

Ensure Go audit-mode interceptors remain non-blocking when validator or mutator invocation returns an error.

Motivation and Context

SEP says audit-mode interceptors MUST NOT block execution regardless of results. The Go SDK already avoided blocking on audit-mode validation findings, but validator/mutator handler or RPC errors could still abort unless FailOpen was set.

This change makes audit mode consistently non-blocking for invocation errors as well, matching the existing C# orchestrator behavior where isAudit || failOpen allows execution to continue.

How Has This Been Tested?

Added focused Go chain tests covering audit-mode validator and mutator errors.

Breaking Changes

None. This only relaxes audit-mode error handling to match SEP semantics.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

C# already treats audit-mode invocation failures as non-blocking. This aligns the Go chain behavior with that implementation and SEP audit-mode semantics.

Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
@jeongukjae
jeongukjae requested a review from Degiorgio August 11, 2026 16:02
@olaservo
olaservo merged commit 1a3e5ef into main Aug 12, 2026
11 checks passed
@olaservo
olaservo deleted the jeongukjae/go-audit-mode-nonblocking branch August 12, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants