Go SDK: Keep audit interceptors non-blocking on errors - #36
Merged
Conversation
Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
Degiorgio
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure Go audit-mode interceptors remain non-blocking when validator or mutator invocation returns an error.
Motivation and Context
SEP says audit-mode interceptors MUST NOT block execution regardless of results. The Go SDK already avoided blocking on audit-mode validation findings, but validator/mutator handler or RPC errors could still abort unless
FailOpenwas set.This change makes audit mode consistently non-blocking for invocation errors as well, matching the existing C# orchestrator behavior where
isAudit || failOpenallows execution to continue.How Has This Been Tested?
Added focused Go chain tests covering audit-mode validator and mutator errors.
Breaking Changes
None. This only relaxes audit-mode error handling to match SEP semantics.
Types of changes
Checklist
Additional context
C# already treats audit-mode invocation failures as non-blocking. This aligns the Go chain behavior with that implementation and SEP audit-mode semantics.