Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go/sdk/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ ext := extension.New()
ext.AddInterceptor(&interceptors.Validator{
Metadata: interceptors.Metadata{
Name: "block-dangerous",
Hook: interceptors.Hook{
Hooks: []interceptors.Hook{{
Events: []string{interceptors.EventToolsCall},
Phase: interceptors.PhaseRequest,
},
}},
Mode: interceptors.ModeEnforce,
},
Handler: func(_ context.Context, inv *interceptors.Invocation) (*interceptors.ValidationResult, error) {
Expand Down
4 changes: 2 additions & 2 deletions go/sdk/examples/mutator/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ func main() {
m := &interceptors.Mutator{
Metadata: interceptors.Metadata{
Name: "audit-tag",
Hook: interceptors.Hook{
Hooks: []interceptors.Hook{{
Events: []string{interceptors.EventToolsCall},
Phase: interceptors.PhaseResponse,
},
}},
Mode: interceptors.ModeEnforce,
},
Handler: func(_ context.Context, inv *interceptors.Invocation) (*interceptors.MutationResult, error) {
Expand Down
4 changes: 2 additions & 2 deletions go/sdk/examples/validator/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ func main() {
v := &interceptors.Validator{
Metadata: interceptors.Metadata{
Name: "block-dangerous-tool",
Hook: interceptors.Hook{
Hooks: []interceptors.Hook{{
Events: []string{interceptors.EventToolsCall},
Phase: interceptors.PhaseRequest,
},
}},
Mode: interceptors.ModeEnforce,
},
Handler: func(_ context.Context, inv *interceptors.Invocation) (*interceptors.ValidationResult, error) {
Expand Down
21 changes: 13 additions & 8 deletions go/sdk/interceptors/chain/chain.go
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,7 @@ func (c *Chain) Execute(ctx context.Context, params *ExecutionParams) (*Executio
if len(nameFilter) > 0 && !nameFilter[e.Interceptor.Name] {
continue
}
if !matchesPhase(e.Interceptor.Hook.Phase, params.Phase) {
continue
}
if !slices.Contains(e.Interceptor.Hook.Events, params.Event) {
if !matchesHooks(e.Interceptor.Hooks, params.Event, params.Phase) {
continue
}
switch e.Interceptor.Type {
Expand Down Expand Up @@ -432,8 +429,16 @@ func (c *Chain) timeoutResult(cr *ExecutionResult, start time.Time) {
})
}

// matchesPhase checks if an interceptor's configured phase covers the target
// phase. An interceptor with PhaseBoth matches any target phase.
func matchesPhase(interceptorPhase, targetPhase interceptors.InterceptionPhase) bool {
return interceptorPhase == interceptors.PhaseBoth || interceptorPhase == targetPhase
// matchesHooks checks if any hook entry matches both the target event and phase.
// A hook with PhaseBoth matches any target phase.
func matchesHooks(hooks []interceptors.Hook, event string, phase interceptors.InterceptionPhase) bool {
for _, h := range hooks {
if h.Phase != interceptors.PhaseBoth && h.Phase != phase {
continue
}
if slices.Contains(h.Events, event) {
return true
}
}
return false
}
26 changes: 14 additions & 12 deletions go/sdk/interceptors/chain/chain_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,12 @@ func registerInterceptorMethods(server *mcp.Server, is []interceptors.Intercepto
for _, i := range is {
if event != "" {
match := false
for _, e := range i.GetMetadata().Hook.Events {
if e == event {
match = true
break
for _, h := range i.GetMetadata().Hooks {
for _, e := range h.Events {
if e == event {
match = true
break
}
}
}
if !match {
Expand Down Expand Up @@ -142,10 +144,10 @@ func TestChain_FailOpenRecordsExecutionResult(t *testing.T) {
failOpenValidator := &interceptors.Validator{
Metadata: interceptors.Metadata{
Name: "fo-validator",
Hook: interceptors.Hook{
Hooks: []interceptors.Hook{{
Events: []string{"test/event"},
Phase: interceptors.PhaseRequest,
},
}},
Mode: interceptors.ModeEnforce,
FailOpen: true,
},
Expand All @@ -156,10 +158,10 @@ func TestChain_FailOpenRecordsExecutionResult(t *testing.T) {
passingValidator := &interceptors.Validator{
Metadata: interceptors.Metadata{
Name: "passing-validator",
Hook: interceptors.Hook{
Hooks: []interceptors.Hook{{
Events: []string{"test/event"},
Phase: interceptors.PhaseRequest,
},
}},
Mode: interceptors.ModeEnforce,
},
Handler: func(_ context.Context, _ *interceptors.Invocation) (*interceptors.ValidationResult, error) {
Expand Down Expand Up @@ -190,10 +192,10 @@ func TestChain_FailOpenRecordsExecutionResult(t *testing.T) {
failOpenMutator := &interceptors.Mutator{
Metadata: interceptors.Metadata{
Name: "fo-mutator",
Hook: interceptors.Hook{
Hooks: []interceptors.Hook{{
Events: []string{"test/event"},
Phase: interceptors.PhaseResponse,
},
}},
Mode: interceptors.ModeEnforce,
FailOpen: true,
PriorityHint: interceptors.NewPriority(10),
Expand All @@ -205,10 +207,10 @@ func TestChain_FailOpenRecordsExecutionResult(t *testing.T) {
passingMutator := &interceptors.Mutator{
Metadata: interceptors.Metadata{
Name: "passing-mutator",
Hook: interceptors.Hook{
Hooks: []interceptors.Hook{{
Events: []string{"test/event"},
Phase: interceptors.PhaseResponse,
},
}},
Mode: interceptors.ModeEnforce,
PriorityHint: interceptors.NewPriority(20),
},
Expand Down
8 changes: 4 additions & 4 deletions go/sdk/interceptors/doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@
// v := &interceptors.Validator{
// Metadata: interceptors.Metadata{
// Name: "block-dangerous-tool",
// Hook: interceptors.Hook{
// Hooks: []interceptors.Hook{{
// Events: []string{"tools/call"},
// Phase: interceptors.PhaseRequest,
// },
// }},
// Mode: interceptors.ModeEnforce,
// },
// Handler: func(ctx context.Context, inv *interceptors.Invocation) (*interceptors.ValidationResult, error) {
Expand All @@ -73,10 +73,10 @@
// m := &interceptors.Mutator{
// Metadata: interceptors.Metadata{
// Name: "redact-pii",
// Hook: interceptors.Hook{
// Hooks: []interceptors.Hook{{
// Events: []string{"tools/call"},
// Phase: interceptors.PhaseResponse,
// },
// }},
// Mode: interceptors.ModeEnforce,
// },
// Handler: func(ctx context.Context, inv *interceptors.Invocation) (*interceptors.MutationResult, error) {
Expand Down
11 changes: 10 additions & 1 deletion go/sdk/interceptors/extension/rpc.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ func (e *Extension) handleList(_ context.Context, req *mcp.ServerRequest[*interc
all := e.getInterceptors()
infos := make([]interceptors.InterceptorInfo, 0, len(all))
for _, ri := range all {
if event != "" && !slices.Contains(ri.GetMetadata().Hook.Events, event) {
if event != "" && !hooksContainEvent(ri.GetMetadata().Hooks, event) {
continue
}
infos = append(infos, interceptors.InfoFromInterceptor(ri))
Expand Down Expand Up @@ -105,3 +105,12 @@ func (e *Extension) handleInvoke(ctx context.Context, req *mcp.ServerRequest[*in

return result, nil
}

func hooksContainEvent(hooks []interceptors.Hook, event string) bool {
for _, h := range hooks {
if slices.Contains(h.Events, event) {
return true
}
}
return false
}
16 changes: 8 additions & 8 deletions go/sdk/interceptors/extension/rpc_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ func TestListWithEventFilter(t *testing.T) {
promptsValidator := &interceptors.Validator{
Metadata: interceptors.Metadata{
Name: "prompts-v",
Hook: interceptors.Hook{
Hooks: []interceptors.Hook{{
Events: []string{interceptors.EventPromptsGet},
Phase: interceptors.PhaseRequest,
},
}},
Mode: interceptors.ModeEnforce,
},
Handler: func(_ context.Context, _ *interceptors.Invocation) (*interceptors.ValidationResult, error) {
Expand Down Expand Up @@ -112,10 +112,10 @@ func TestInvokeValidatorRejects(t *testing.T) {
rejectAll := &interceptors.Validator{
Metadata: interceptors.Metadata{
Name: "reject-all",
Hook: interceptors.Hook{
Hooks: []interceptors.Hook{{
Events: []string{interceptors.EventToolsCall},
Phase: interceptors.PhaseRequest,
},
}},
Mode: interceptors.ModeEnforce,
},
Handler: func(_ context.Context, _ *interceptors.Invocation) (*interceptors.ValidationResult, error) {
Expand Down Expand Up @@ -155,10 +155,10 @@ func TestInvokeMutator(t *testing.T) {
mutator := &interceptors.Mutator{
Metadata: interceptors.Metadata{
Name: "add-field",
Hook: interceptors.Hook{
Hooks: []interceptors.Hook{{
Events: []string{interceptors.EventToolsCall},
Phase: interceptors.PhaseRequest,
},
}},
Mode: interceptors.ModeEnforce,
},
Handler: func(_ context.Context, inv *interceptors.Invocation) (*interceptors.MutationResult, error) {
Expand Down Expand Up @@ -231,10 +231,10 @@ func TestInvokeTimeout(t *testing.T) {
slowValidator := &interceptors.Validator{
Metadata: interceptors.Metadata{
Name: "slow-v",
Hook: interceptors.Hook{
Hooks: []interceptors.Hook{{
Events: []string{interceptors.EventToolsCall},
Phase: interceptors.PhaseRequest,
},
}},
Mode: interceptors.ModeEnforce,
},
Handler: func(ctx context.Context, _ *interceptors.Invocation) (*interceptors.ValidationResult, error) {
Expand Down
6 changes: 4 additions & 2 deletions go/sdk/interceptors/extension/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,10 @@ func (e *Extension) enrichInitResult(result mcp.Result) (mcp.Result, error) {
all := e.getInterceptors()
supportedEvents := map[string]bool{}
for _, ri := range all {
for _, ev := range ri.GetMetadata().Hook.Events {
supportedEvents[ev] = true
for _, h := range ri.GetMetadata().Hooks {
for _, ev := range h.Events {
supportedEvents[ev] = true
}
}
}

Expand Down
Loading
Loading