Skip to content

un-skip tests on Windows V19H1 (1903) and up #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

un-skip tests on Windows V19H1 (1903) and up #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions changes_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,10 +245,6 @@ func TestChangesWithChangesGH13590(t *testing.T) {

// Create a directory, copy it, make sure we report no changes between the two
func TestChangesDirsEmpty(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("FIXME: broken on Windows 1903 and up; see https://github.com/moby/moby/pull/39846")
}

src, err := os.MkdirTemp("", "docker-changes-test")
assert.NilError(t, err)
defer os.RemoveAll(src)
Expand Down Expand Up @@ -331,10 +327,6 @@ func mutateSampleDir(t *testing.T, root string) {
}

func TestChangesDirsMutated(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("FIXME: broken on Windows 1903 and up; see https://github.com/moby/moby/pull/39846")
}

src, err := os.MkdirTemp("", "docker-changes-test")
assert.NilError(t, err)
createSampleDir(t, src)
Expand Down
Loading