Open
Conversation
zenhack
approved these changes
Mar 17, 2023
zenhack
left a comment
zenhack
left a comment
There was a problem hiding this comment.
To clarify re: tempest, "not supported" means it will just use "grain" for things that don't have nounPhrase set, rather than jump through hoops to infer something better like "shared directory."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Davros currently relies on a messy hack in Sandstorm to generate the "Create new shared directory" text, as nounPhrase was implemented over eight years ago: https://github.com/sandstorm-io/sandstorm/blob/2b0bcfa0a0eec3b9b0c7de9c80161c9eb165a052/shell/imports/sandstorm-db/db.js#L2381-L2412
The comment describes a desire to remove this hack, so we should update apps which rely on it to set this. Additionally, Tempest is not supporting this legacy hack, so this patch will improve Davros support in Tempest.
We might not fix this with every package, but since Davros tends to be pretty heavily used, and there's already a few good fixes in the wings for it's next release, I wanted to get this PR open.
cc: @zenhack