Fix Pi approval UI duplication and remove public debug slash commands#416
Merged
mmprotest merged 1 commit intoJun 29, 2026
Conversation
3efef13
into
mmprotest/implement-pi-integration-as-external-adapter
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
[object Object]./villanicommand is exposed while keeping internal helpers intact.Description
integrations/pi-villani/src/index.ts).approvalMessageso the confirm body contains only operation-specific details (Command:/File:/Operation:) and ends withApprove this Villani action?, avoiding title repetition and[object Object]output (changes inintegrations/pi-villani/src/index.ts).approval_requiredclears any widget and sets a brief approval status, andapproval_resolvedsets short accepted/denied continuation copy (changes inintegrations/pi-villani/src/render.ts)./villani-abort,/villani-confirm-test,/villani-ping,/villani-doctor,/villani-bridge-ping,/villani-proxy-test) so only/villaniis registered (changes inintegrations/pi-villani/src/index.ts).integrations/pi-villani/src/*.test.tsandintegrations/pi-villani/README.md).Testing
cd integrations/pi-villani && npm test, and all integration/unit tests passed (91tests passed,0failed)./villaniis registered publicly and to validate the approval lifecycle: widget cleared before confirm, concise status text, non-repetitive titles/bodies for Read/Bash/Write/Patch, noPending approvalorAllow this operation?, no[object Object], and that accepted/denied both clear the widget.Codex Task