Fix Pi Villani UI status and approval copy#415
Merged
mmprotest merged 1 commit intoJun 29, 2026
Merged
Conversation
304a100
into
mmprotest/implement-pi-integration-as-external-adapter
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
[object Object]orPending approval.Description
approvalcopy category and approval-specific phrases inintegrations/pi-villani/src/render.tsviaVILLANI_COPYandVillaniCopyCategoryupdates.nextVillaniStatus,shouldUpdateStatus,resetVillaniStatusManager, andcurrentStatusFallbackto suppress repeated rotations and only change status on category/detail/time transitions.reduceVillaniUiStateandrenderStateto usenextVillaniStatus(...)and avoid re-rendering identical status strings, and keptstream_textassistant output literal viacleanAssistantText.integrations/pi-villani/src/index.tsto use Villani-style titles and messages (approvalTitle,approvalLead,approvalMessage), set the approval widget toVillaniclearance required, and usenextVillaniStatus("approval", requestId)for approval status updates.integrations/pi-villani/src/*.test.tsto cover throttling, approval copy, widget content, and preservation of literal assistant stream text.Testing
npm testinsideintegrations/pi-villani, and all tests passed (93tests,0failures).integrations/pi-villani/src/render.test.tsandintegrations/pi-villani/src/extension.test.ts).Codex Task