Add COSMO example notebook for onboarding (#587)#392
Conversation
e27e1fe to
83b9421
Compare
|
Hi @sadamov , I’ve updated this PR to a COSMO example notebook as discussed. The notebook and changelog have been revised accordingly. Please let me know if any further changes are needed. |
There was a problem hiding this comment.
I think there was a misunderstanding here: the notebook for cosmo is already created. There are however some outstanding issues that need to be adressed, as mentioned in:
@info-gallary great, you will face one main obstacle. Currently the cosmo data is hosted on the ETH research collection and is multiple 100GB in size. so for a hello world example we will need to host a tiny piece of that data on a more accessible storage option, similar to DANRA. You might want to convert this .md file to a jupyter notebook. Here is my md file for cosmo: https://github.com/joeloskarsson/neural-lam-dev/blob/research/docs/reproduce_paper_sample.md
also #69 is mostly talking about danra, so you shouldn't close that issue with this PR.
So to rephrase, the issue about the COSMO hello world example is: how to bring the notebook from the research branch into main and get it to run in a reasonable amout of time. The preparation and hosting of a readuced cosmo sample is very much the core work. I do understand that hosting data is not simple/cheap, but it is required here. Since this PR is not solving the issues I'll mark it as draft for now.
If you would like to start working on the example data hosting I suggest to contact @leifdenby as he has some options from what I understand 😉
|
Thanks for the clarification, that makes sense. I understand now that the core missing work is preparing and hosting a reduced COSMO sample so the notebook can actually run in a reasonable time, rather than only converting the existing notebook into main. I’ll avoid closing #69 from this PR. I’d still be interested in helping with the reduced sample data preparation/hosting side. I’ll reach out to @leifdenby to better understand the available hosting options and what would be most useful here.
|
|
Okay I organized the hello_world issue and PRs:
If there was some oversight let me know, tried my best to look through all previous comms. |
Describe your changes
This PR adds a new onboarding example notebook docs/notebooks/COSMO_example.ipynb that demonstrates the full Neural-LAM workflow (Datastore → Graph → Training → Evaluation → Visualization) using a COSMO-structured setup.
Key Improvements:
docs/notebooks/directory to follow the project's organizational patterns.HelloWorld.ipynbto avoid overlap with existing DANRA notebook work.Motivation:
The maintainers requested a COSMO-specific example to serve as the primary onboarding documentation, replacing the previous general "hello world" implementation.
Dependencies:
neural-lammllam-data-prep(demonstrated in config)weather-model-graphs(demonstrated in graph construction)numpy,xarray,pandas,torch,pyyamlIssue Link
closes #587
Type of change
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Author checklist after completed review
COSMO_example.ipynbnotebook to documentation for onboardingChecklist for assignee