Dropout fix [PyTorch]: Move dropout_rate from model init to model fwd pass
#873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Niccolo-Ajroldi
changed the title
dropout_rate from model init to model fwd pass
priyakasimbeg
approved these changes
Jun 18, 2025
priyakasimbeg
merged commit 6b6f2a6
into
mlcommons:dropout_support
6 of 16 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce
dropout_ratein the model call (fwd pass), and modify model implementations to support a dynamicdropout_ratevalue. Consequently, we removedropout_ratefrom the model initialization, and adapt the workloads to support this new paradigm.More details in this discussion: #753 (comment)
Tests for model equivalence are available at: https://github.com/Niccolo-Ajroldi/algorithmic-efficiency/tree/dropout_pytorch/tests/dropout_fix