Add missing env variables to start_ssh.py #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to pass these variables to `update_authorized_keys.py` 1. `SSH_TARGET_PUBLICKEY_API_PORT` to override the API port 2. Kubernetes info so the `config.load_incluster_config()` can work Signed-off-by: Ash Wu <[email protected]> Signed-off-by: Timothy Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to pass these variables to
update_authorized_keys.pySSH_TARGET_PUBLICKEY_API_PORTto override the API portconfig.load_incluster_config()can workReferences:
Signed-off-by: Ash Wu [email protected]
Signed-off-by: Timothy Lee [email protected]
What kind of change does this PR introduce?
Description:
Checklist: