added leela chess zero engine (cpu version) and stockfish 16#282
Open
KudahShambare wants to merge 1 commit intoml-research:masterfrom
Open
added leela chess zero engine (cpu version) and stockfish 16#282KudahShambare wants to merge 1 commit intoml-research:masterfrom
KudahShambare wants to merge 1 commit intoml-research:masterfrom
Conversation
Collaborator
|
Hello @KudahShambare , |
Author
|
@QueensGambit Thanks for the feedback let me fix the issues |
Author
|
@QueensGambit just a quick question. If I download the binaries and insert them into the engines directory. Do I need to also include the code to download it from it's main repository? |
Collaborator
|
Hi, I would prefer that you don't upload binaries but update the postinstall.js script accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Added 2 additional engines
Pre-merge TODOs and Checks