Security: Potential XSS via unsanitized highlighted content rendered with dangerouslySetInnerHTML#341
Open
tuanaiseo wants to merge 19 commits intomksglu:nextfrom
Conversation
The search results view renders HTML using `dangerouslySetInnerHTML` and prefers `r.highlighted` when present. While `r.content` is escaped via `esc()`, `r.highlighted` is inserted without sanitization. If `highlighted` can be influenced by user-controlled indexed content or backend responses, an attacker could inject arbitrary HTML/JS (stored or reflected XSS). Affected files: search.tsx Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The search results view renders HTML using
dangerouslySetInnerHTMLand prefersr.highlightedwhen present. Whiler.contentis escaped viaesc(),r.highlightedis inserted without sanitization. Ifhighlightedcan be influenced by user-controlled indexed content or backend responses, an attacker could inject arbitrary HTML/JS (stored or reflected XSS).Severity:
highFile:
insight/src/routes/search.tsxSolution
Avoid
dangerouslySetInnerHTMLfor search highlights. Return structured highlight spans from the backend or sanitizer.highlightedwith a robust HTML sanitizer (e.g., DOMPurify) before rendering. Prefer rendering text nodes and explicit<mark>elements instead of raw HTML.Changes
insight/src/routes/search.tsx(modified)Testing