Conversation
Added replacements for various characters including fullwidth symbols and quotation marks.
Owner
|
The reason I replaced "/" for example is that it's not allowed in a filename since it's the path separator. But all these other ones (question mark, quotes, etc.) are allowed in filenames, at least on Linux and macOS. |
Author
|
Ah, yes, I ran into this specifically on windows, which has a larger list of prohibited characters. For Linux and macOS I agree it's unnecessary - and probably visually annoying to have fullwidth characters when not needed. For windows, the script errored and stopped when hitting a question mark in a chat title. I'm totally fine if you want to keep the code targeted for Linux and macOS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added replacements for various characters including fullwidth symbols, quotation marks, new lines and leading/trailing spaces.