update taskflow api

[mjunaidca]

No description provided.

[Copilot]

Pull request overview

This PR refactors the taskflow API to improve transaction management and avoid SQLAlchemy detached object issues. The changes focus on consolidating database commits, extracting primitive values before transactions, and explicitly passing actor type information to audit logs.

Key Changes:

• Consolidated multiple commits into single transactions by using flush() to get IDs without committing
• Extract primitive values (IDs, types) immediately from ORM objects to prevent detached object issues
• Updated log_action() to accept actor_type as a parameter instead of querying it, removing unnecessary database lookups

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/api/src/taskflow_api/services/user_setup.py	Updated ensure_default_project to accept worker_id as int parameter instead of Worker object; added session refresh to prevent detached objects
packages/api/src/taskflow_api/services/audit.py	Removed Worker import and database lookup; added actor_type parameter with default value; removed commit/refresh logic to allow caller to control transactions
packages/api/src/taskflow_api/schemas/task.py	Added strip_timezone() utility function and field validators for converting 0 to None for foreign keys and normalizing datetime values
packages/api/src/taskflow_api/routers/tasks.py	Extracted worker IDs and types before commits; consolidated commits with flush pattern; updated all log_action calls to pass actor_type; replaced some task_to_read calls with manual TaskRead construction
packages/api/src/taskflow_api/routers/projects.py	Extracted worker and project IDs before commits; consolidated transaction commits; updated audit log calls with actor_type parameter
packages/api/src/taskflow_api/routers/members.py	Extracted worker IDs and member details before commits; consolidated commits; updated audit logging with explicit actor_type
packages/api/src/taskflow_api/routers/agents.py	Extracted worker IDs and agent details before commits or deletions; consolidated transaction commits; updated audit log calls with actor_type parameter

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Remove this unnecessary blank line between the comment and the code. It disrupts the flow and is inconsistent with coding style conventions.

Suggested change

[Copilot]

Potential None dereference: member_worker could theoretically be None at this point if neither the agent_id nor user_id branches are executed (though the validation at lines 81-84 should prevent this). Consider adding an assertion or explicit check before accessing member_worker.handle, member_worker.name, and member_worker.type to make the code more robust and satisfy type checkers:

if not member_worker:
    raise HTTPException(status_code=500, detail="Internal error: member_worker not initialized")

Suggested change

	# Get member details for response before commit
	# Get member details for response before commit
	if not member_worker:
	raise HTTPException(status_code=500, detail="Internal error: member_worker not initialized")