Skip to content

feat: improve performance in AirportSupplier by resolving the provide… #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mivek merged 1 commit into from
Jun 12, 2025
Merged

feat: improve performance in AirportSupplier by resolving the provide… #688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions metarParser-parsers/src/main/java/io/github/mivek/command/AirportSupplier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,28 @@
import io.github.mivek.model.Airport;
import io.github.mivek.provider.airport.AirportProvider;
import io.github.mivek.provider.airport.impl.DefaultAirportProvider;

import java.util.Iterator;
import java.util.ServiceLoader;

/**
* @author mivek
*/
public final class AirportSupplier implements Supplier<Airport> {
/** The service loader for the airport provider. */
private final ServiceLoader<AirportProvider> airportLoader;
/** The airport provider. */
private final AirportProvider provider;

/**
* Constructor.
*/
public AirportSupplier() {
airportLoader = ServiceLoader.load(AirportProvider.class);
ServiceLoader<AirportProvider> loader = ServiceLoader.load(AirportProvider.class);
Iterator<AirportProvider> iterator = loader.iterator();
this.provider = iterator.hasNext() ? iterator.next() : new DefaultAirportProvider();
Comment thread
mivek marked this conversation as resolved.
}

@Override
public Airport get(final String string) {
AirportProvider provider = airportLoader.iterator().hasNext() ? airportLoader.iterator().next() : new DefaultAirportProvider();
return provider.getAirports().get(string);
}
}
Expand Down