Skip to content

Add feature to set SSH private/public key field #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2025
Merged

Add feature to set SSH private/public key field #102

merged 2 commits into from
Aug 19, 2025

Conversation

jkupferer
Copy link
Contributor

@jkupferer
Add feature to set SSH private/public key field
2c819cb 
- Add ability set privateKeyField and publicKeyField to set secret
  fields to store SSH private/public keys.
- Resolves mittwald#92
@systemstart
Copy link

@jkupferer : Hi. The Test GH Action in your PR seems to be stuck. Close/Reopen the PR might help.

@lee-baines
Copy link

Is this still being worked on?

@jkupferer
Copy link
Contributor Author

Circling back around to this... updating the PR branch.
@lee-baines The feature is fully implemented, but someone would need to approve the test for it to move forward. I'm not sure who needs to do that? I don't want to maintain my own fork for this feature...

@lee-baines
Copy link

Thanks @jkupferer. I'm not sure. Is there an obvious person/group to add to the reviewers in the top right? I'm guessing as there are no reviewers, no-one is picking this up

@hensur hensur merged commit d386121 into mittwald:master Aug 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hensur hensur hensur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Customization of ssh-privatekey and ssh-publickey for SSHKeyPair
4 participants
@jkupferer @systemstart @lee-baines @hensur