Conversation
There was a problem hiding this comment.
Pull request overview
This pull request performs dependency updates and code formatting improvements. The PR title "up" is terse but appears to indicate an "update" operation.
Changes:
- Removed unnecessary
argparsedependency (correctly, as it's Python stdlib) - Updated multiple dependencies to newer versions (cfgv, filelock, identify, jsonschema, nodeenv, packaging, platformdirs, pre-commit, pydantic, pydantic-core, rpds-py, ruff, virtualenv)
- Applied code formatting changes (trailing commas) to maintain consistency
- Updated pre-commit hooks with additional checks
- Changed from
[project.optional-dependencies]to[dependency-groups](breaking change) - Fixed typo in CHANGELOG.md
- Introduced typo in README.md (NWO → NOW)
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Updated dependency versions and removed argparse package |
| tests/test_main_cli.py | Applied code formatting (trailing commas) |
| mite_schema/main.py | Applied code formatting (trailing commas) |
| pyproject.toml | Restructured configuration, changed dependency management approach, and removed argparse |
| .pre-commit-config.yaml | Added new hooks and updated versions, disabled pytest hook |
| README.md | Changed NWO to NOW (incorrect change) |
| CHANGELOG.md | Fixed typo: peristing → persisting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "ruff~=0.13" | ||
| ] | ||
| [dependency-groups] | ||
| dev = ["pre-commit~=4.3", "pytest~=8.4", "ruff~=0.13"] |
There was a problem hiding this comment.
The pyproject.toml specifies ruff~=0.13 in the dev dependency group, but uv.lock has resolved to version 0.14.14. The ~= operator allows minor version updates (0.13.x) but should not allow 0.14.x. This indicates the lockfile is inconsistent with the dependency specification. Either update pyproject.toml to ruff~=0.14 to match the locked version, or regenerate the lockfile with the correct version constraint.
| dev = ["pre-commit~=4.3", "pytest~=8.4", "ruff~=0.13"] | |
| dev = ["pre-commit~=4.3", "pytest~=8.4", "ruff~=0.14"] |
|
|
||
| [project.scripts] | ||
| mite_schema = "mite_schema.main:main" | ||
|
|
There was a problem hiding this comment.
The change from [project.optional-dependencies] to [dependency-groups] is a significant breaking change for users. The [project.optional-dependencies] section is a PEP 621 standard that allows installing dev dependencies with pip install .[dev]. The [dependency-groups] section is a uv-specific feature (PEP 735) that requires users to use uv for installation. This change will break existing workflows for users who install the package with pip using pip install -e .[dev]. Consider maintaining backward compatibility or documenting this breaking change clearly.
| [project.optional-dependencies] | |
| dev = ["pre-commit~=4.3", "pytest~=8.4", "ruff~=0.13"] |
.pre-commit-config.yaml
Outdated
| # - id: pytest | ||
| # name: pytest | ||
| # entry: uv run pytest | ||
| # pass_filenames: false | ||
| # language: system |
There was a problem hiding this comment.
The pytest pre-commit hook has been commented out without explanation. This means tests will no longer run automatically on commit, which could lead to committing broken code. If this was intentional, it should be documented. If tests are slow or problematic, consider making this hook optional or running tests only on specific files. The commented-out hook also shows pass_filenames: false was added, which is a good practice for pytest.
|
@mmzdouc ready! |
1 participant
No description provided.