Open
Conversation
Change batchproof serialization to use varints, saving space for disk and bandwidth for network.
UndoBlocks need to be saved and re-accessed whenever there is a reorg with the Bitcoin blockchain. Serialization and Deserialization is added so that these blocks can be saved and fetched from disk. UndoBlocks are also now exported so that callers will be able to access the new Serialize() and Deserialize() methods.
utcd has many optimizations that btcd doesn't have. Switching to utcd speeds things up drastically for the binaries in cmd/. We won't be pointing to the branch utreexo in utcd as breaking changes to the accumulator package will result in utcd failing to build. This makes changes annoying to deal with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done:
accumulator: Use varints for serializationimports thewirepackage and uses the varint serialization functions for batchproof.accumulator/undo: Add serialization for undoblocksadds undoblock serialization/deserialization (uses varint) and exportsUndoBlockto expose the serialization functions.go.mod, go.sum: Switch to the btcd++ branch in utcdnow imports utcd instead of btcd. However, it only imports the btcd++ branch as that branch doesn't have any utreexo specific packages, therefore not creating any dependency cycles.This PR doesn't produce backwards compatible proofs as the serialization is different.