Skip to content

Fix: Label updating issue #2841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Label updating issue #2841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions commands/issue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,15 @@ func updateIssue(cmd *Command, args *Args) {
setAssigneesFromArgs(params, args)
setMilestoneFromArgs(params, args, gh, project)

labels, err := gh.FetchIssueLabels(project, issueNumber)
utils.Check(err)

for _, label := range labels {
res := []string{}
res = append(res, label.Name)
params["labels"] = res
}

if args.Flag.HasReceived("--state") {
params["state"] = args.Flag.Value("--state")
}
Expand Down
30 changes: 30 additions & 0 deletions github/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,6 +866,36 @@ func (client *Client) FetchLabels(project *Project) (labels []IssueLabel, err er
return
}

func (client *Client) FetchIssueLabels(project *Project, issueNumber int) (labels []IssueLabel, err error) {
api, err := client.simpleAPI()
if err != nil {
return
}

path := fmt.Sprintf("repos/%s/%s/issues/%d/labels?per_page=100", project.Owner, project.Name, issueNumber)

labels = []IssueLabel{}
var res *simpleResponse

for path != "" {
res, err = api.Get(path)
if err = checkStatus(200, "fetching labels", res, err); err != nil {
return
}
path = res.Link("next")

labelsPage := []IssueLabel{}
if err = res.Unmarshal(&labelsPage); err != nil {
return
}
labels = append(labels, labelsPage...)
}

sort.Sort(sortedLabels(labels))

return
}

func (client *Client) FetchMilestones(project *Project) (milestones []Milestone, err error) {
api, err := client.simpleAPI()
if err != nil {
Expand Down