Skip to content

Adding Travis CI script, etc. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

john-peterson
Copy link
Member

No description provided.

@john-peterson
Copy link
Member Author

Changing the Core.jar entry point

Problem

Running Core.jar created by build/newBuild/build.xml return an error

java -jar update/dist/Core.jar
Error: Could not find or load main class jd.Main

Solution

Changing the Core.jar entry point from jd.Main to org.jdownloader.startup.Main because

  • that allow it to run

@john-peterson
Copy link
Member Author

Merging Core.jar and JDownloader.jar

Problem

The code is organised in multiple (2) instead of 1 .jar

in approximately equal sizes (2 MiB of the total 4 MiB .jar size)

based on

  • code update frequency

because

  • this reduce update bandwidth because the infrequently updated code doesn't have to be downloaded together with the frequently updated code

This is a problem because

it doesn't significantly reduce update bandwidth because

  • to reduce bandwidth significantly a significant portion of the code should be in the less frequently updated .jar
  • in a significant portion (compared to a non-significant portion) of the code there will often be changes somewhere
  • the JDownloader.jar code is often changed too, requiring update of this .jar too

the build script to separate code in different .jar is more complex with the result that

  • refactoring require changes to the build script because many class paths are defined in the build script

Solution

Distributing all program (rather than non-program i.o.w. library) code in one .jar because

  • the increase in update bandwidth isn't costly
  • the time to update the build script is costly

because that allow it to run in other environments
because that allow it to run
because it doesn't have meaning when the build/newBuild/build.xml output update/dist/JDownloader.jar can be used instead of dev/JDownloader.jar
because it's useful to test a build
@john-peterson
Copy link
Member Author

Removing dev/JDownloader.jar

Problem

Compiled code is in dev/JDownloader.jar because

  • that avoid the need to update build/newBuild/build.xml to build a working update/dist/Core.jar

This is a problem because

  • it's better to update the build script than use compiled code from a previous version

Solution

Removing dev/JDownloader.jar because

  • it doesn't have meaning when the build/newBuild/build.xml output update/dist/JDownloader.jar can be used instead of dev/JDownloader.jar

@john-peterson
Copy link
Member Author

Removing unused projects from build script

Solution

Removing

  • JDownloaderServerOptions
  • JDownloaderUpdater

because

  • they aren't used
  • the build otherwise return an error
ant -Dbasedir=. -Dbuild.compiler=org.eclipse.jdt.core.JDTCompilerAdapter -lib jdtCompilerAdapter.jar -lib /usr/lib/eclipse/plugins/org.eclipse.jdt.core_*.dist.jar -f build/newBuild/build.xml withoutsign
BUILD FAILED
/mnt/hgfs/shared/source/program/jdownloader/repo/build/newBuild/build.xml:75: srcdir "/mnt/hgfs/shared/source/program/jdownloader/JDownloaderUpdater/src" does not exist!

MXEBot pushed a commit that referenced this pull request Mar 8, 2018
git-svn-id: svn://svn.jdownloader.org/jdownloader/trunk@38861 ebf7c1c2-ba36-0410-9fe8-c592906822b4
MXEBot pushed a commit that referenced this pull request Dec 16, 2019
git-svn-id: svn://svn.jdownloader.org/jdownloader/trunk@41619 ebf7c1c2-ba36-0410-9fe8-c592906822b4
MXEBot pushed a commit that referenced this pull request Mar 19, 2020
- [YetiShare] brfilescom: added comment regarding possible serverside GEO-block refs #87810
- pornhubcom: decryptAllVideosOfAPornstar: bugfix attempt #2 RE: forum 83478
- tube8com: Added workaround for redirectloop on URLs containing dots fixes #86825 fixes #87811
- playvidcom: fixed filenames fixes #87526
- googledrive: improved errorhandling RE: 83214

*Plugins: RIP*
- fapdu.com: redirects to pornhub.com, their URLs do not have any direct redirects to pornhub but I will not add this one to the offline list either fixes #87808 fixes #86023
- [UnknownPornScript4] bondagebox.com & fetishbox.com: redirects to supported host kink.com but not to specified content - will not add it to offline hosts though fixes #85825 fixes #87812 fixes #87813 fixes #85592

git-svn-id: svn://svn.jdownloader.org/jdownloader/trunk@41900 ebf7c1c2-ba36-0410-9fe8-c592906822b4
MXEBot pushed a commit that referenced this pull request Dec 2, 2020
- 4chan: minor changes
- DirectHTTP: added comment for property "FIXNAME" and make use of that in plugins
- ehentai: workaround attempt #2 RE forum 475660

git-svn-id: svn://svn.jdownloader.org/jdownloader/trunk@43372 ebf7c1c2-ba36-0410-9fe8-c592906822b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant