A-1213877919321098: migrate Cipher to Web Crypto API#252
Merged
Conversation
Replace node-forge and pbkdf2 with native crypto.subtle for PBKDF2, AES-GCM, and random byte generation. Store kdfIterations per account and auto-migrate legacy accounts from 10k to 600k iterations on login.
…r mnemonic generation Replace mouse-drawn entropy with cryptographically secure crypto.getRandomValues(16 bytes) for BIP39 mnemonic generation. Remove Entropy component, related state, and renumber CreateAccount steps from 6 to 5.
owlsua
added
crypto
enhancement
Use encryptionVersion field in accounts instead of raw kdfIterations. Each version inherits from previous, making it easy to add new encryption parameters (encoding, hexWrap, etc.) in future versions.
anyxem
previously approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💬 Description
Migrate Cipher to Web Crypto API
More
📋 Checklist:
A-[id of Asana task]A-[id of Asana task]: [short description]prettierchecklintcheck