Skip to content

Add signal exit-code option #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add signal exit-code option #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ var (
globalHostBalance string
globalTLSCert atomic.Pointer[[]byte]
globalKeyPassword string
globalExitCode int
)

const (
Expand Down Expand Up @@ -1075,6 +1076,7 @@ func sidekickMain(ctx *cli.Context) {
globalHostBalance = "least"
}
globalKeyPassword = ctx.GlobalString("key-password")
globalExitCode = ctx.GlobalInt("exit-code")

tlsMaxVersion := uint16(tls.VersionTLS13)
switch tlsMax := ctx.GlobalString("tls-max"); tlsMax {
Expand Down Expand Up @@ -1242,7 +1244,7 @@ func sidekickMain(ctx *cli.Context) {
})
default:
console.Infof("caught signal '%s'\n", signal)
os.Exit(1)
os.Exit(globalExitCode)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not so keen to add new flags. I think all what you need to do is to run os.Exit(143) when we receive syscall.SIGTERM. Kubernetes will understand that and will not flag an error for the container

}
}
}
Expand Down Expand Up @@ -1381,6 +1383,11 @@ func main() {
Value: "1.3",
Hidden: true,
},
cli.IntFlag{
Name: "exit-code",
Usage: "exit code to use when program terminates by a signal",
Value: 1,
},
}
app.CustomAppHelpTemplate = `NAME:
{{.Name}} - {{.Description}}
Expand Down
Loading