Skip to content

google connectors#206

Merged
martyna-mindsdb merged 3 commits into
stagingfrom
google-connectors-jun19
Jun 22, 2026
Merged

google connectors#206
martyna-mindsdb merged 3 commits into
stagingfrom
google-connectors-jun19

Conversation

@martyna-mindsdb

@martyna-mindsdb martyna-mindsdb commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

This PR has been AI-reviewed.

This PR is related to mindsdb/cowork-server#73

What was done Files
startConnectorOAuth() now accepts and forwards extraFields in the POST body, enabling additional form values (e.g. Google Ads developer token) to be passed to the backend. The browser_oauth_builtin submit flow also sends the current form values as extraFields. api.js
DataVaultFormPanel.jsx
Extracted the OAuth polling logic into a shared startBrowserOAuthPoll(state, successTitle, formId) helper, removing ~40 lines of duplicated interval handling that previously existed across two separate handlers. DataVaultFormPanel.jsx
Poll intervals are now stored in an oauthPollRef and automatically cleared on component unmount, preventing state updates from firing on unmounted components when users navigate away during the OAuth flow. DataVaultFormPanel.jsx

@martyna-mindsdb martyna-mindsdb marked this pull request as draft June 19, 2026 14:15
@martyna-mindsdb martyna-mindsdb marked this pull request as ready for review June 19, 2026 17:32
@martyna-mindsdb martyna-mindsdb requested a review from tino097 June 19, 2026 17:32
@martyna-mindsdb martyna-mindsdb merged commit 07adbaf into staging Jun 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants