Skip to content

Propose fix some typos and ignore emacs backup files #3131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sre-ci-robot merged 4 commits into from
Dec 17, 2025
Merged

Propose fix some typos and ignore emacs backup files #3131

sre-ci-robot merged 4 commits into from
Dec 17, 2025

Conversation

@jeis4wpi
Copy link
Contributor

@jeis4wpi jeis4wpi commented Dec 4, 2025

Propose fix some typos and ignore emacs backup files

@sre-ci-robot
Copy link

sre-ci-robot commented Dec 4, 2025

Welcome @jeis4wpi! It looks like this is your first PR to milvus-io/pymilvus 🎉

@mergify mergify bot added the dco-passed label Dec 4, 2025
@codecov
Copy link

codecov bot commented Dec 17, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@d7c6373). Learn more about missing BASE report.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #3131   +/-   ##
=========================================
  Coverage          ?   46.10%           
=========================================
  Files             ?       66           
  Lines             ?    14214           
  Branches          ?        0           
=========================================
  Hits              ?     6554           
  Misses            ?     7660           
  Partials          ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Dec 17, 2025
@XuanYang-cn
Copy link
Contributor

XuanYang-cn commented Dec 17, 2025

/lgtm
/approve

@sre-ci-robot
Copy link

sre-ci-robot commented Dec 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeis4wpi, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d875186 into milvus-io:master Dec 17, 2025
13 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 17, 2025
@jeis4wpi @XuanYang-cn @github-actions
Propose fix some typos and ignore emacs backup files (#3131)
62b46b4 
Propose fix some typos and ignore emacs backup files

Signed-off-by: John E <[email protected]>
Co-authored-by: XuanYang-cn <[email protected]>
(cherry picked from commit d875186)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@pymilvus-bot
Copy link
Collaborator

pymilvus-bot commented Dec 17, 2025

✅ Backport Created
Hi @jeis4wpi, Backport PR for 2.6 has been created: #3145

(cc @sre-ci-robot)

@pymilvus-bot pymilvus-bot mentioned this pull request Dec 17, 2025
Merged
sre-ci-robot pushed a commit that referenced this pull request Dec 17, 2025
@pymilvus-bot @jeis4wpi @XuanYang-cn
[Backport 2.6] Propose fix some typos and ignore emacs backup files (#…
cedf614 
…3131) (#3145)

Backport of #3131 to `2.6`.

Signed-off-by: John E <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: John Eismeier <[email protected]>
Co-authored-by: XuanYang-cn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XuanYang-cn XuanYang-cn XuanYang-cn approved these changes

@czs007 czs007 Awaiting requested review from czs007

@wangting0128 wangting0128 Awaiting requested review from wangting0128

Assignees

@XuanYang-cn XuanYang-cn

Labels

approved backport-to-2.6 backported ci-passed dco-passed lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeis4wpi @sre-ci-robot @XuanYang-cn @pymilvus-bot