Skip to content

Conversation

@yhmo
Copy link
Collaborator

@yhmo yhmo commented Nov 24, 2025

No description provided.

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 17.97753% with 73 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (2.5@2bed12c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/impl/utils/DqlUtils.cpp 18.46% 53 Missing ⚠️
src/impl/types/QueryArguments.cpp 18.18% 9 Missing ⚠️
src/impl/types/SubSearchRequest.cpp 18.18% 9 Missing ⚠️
src/impl/utils/TypeUtils.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             2.5     #372   +/-   ##
======================================
  Coverage       ?   65.41%           
======================================
  Files          ?       71           
  Lines          ?     8374           
  Branches       ?      953           
======================================
  Hits           ?     5478           
  Misses         ?     2803           
  Partials       ?       93           
Files with missing lines Coverage Δ
src/include/milvus/types/QueryArguments.h 100.00% <ø> (ø)
src/include/milvus/types/SubSearchRequest.h 100.00% <ø> (ø)
src/impl/utils/TypeUtils.cpp 95.05% <0.00%> (ø)
src/impl/types/QueryArguments.cpp 63.73% <18.18%> (ø)
src/impl/types/SubSearchRequest.cpp 70.49% <18.18%> (ø)
src/impl/utils/DqlUtils.cpp 77.04% <18.46%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Nov 24, 2025
@yhmo yhmo added the lgtm label Nov 25, 2025
@sre-ci-robot sre-ci-robot merged commit 8b88656 into milvus-io:2.5 Nov 25, 2025
11 of 12 checks passed
@yhmo yhmo deleted the 25 branch November 25, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants