Skip to content

Fix float to int loses precision notice on QR #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix float to int loses precision notice on QR #202

wants to merge 1 commit into from

Conversation

@erikn69
Copy link
Contributor

@erikn69 erikn69 commented Jul 8, 2025 

Implicit conversion from float 16.5 to int loses precision 
    on vendor/milon/barcode/src/Milon/Barcode/QRcode.php:874 
Implicit conversion from float 3.5 to int loses precision 
    on vendor/milon/barcode/src/Milon/Barcode/QRcode.php:878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@angeljqv angeljqv angeljqv approved these changes

@parallels999 parallels999 parallels999 approved these changes

@jaycee0610 jaycee0610 jaycee0610 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PHP 8.3 DEPRECATED NOTICE: Implicit conversion from float x to int loses precision PHP 8.4 Notice in getBarcodeSVG Implicit conversion from float

4 participants

@erikn69 @angeljqv @parallels999 @jaycee0610