Add missing Japanese translations. - #169
Conversation
|
@logue Thanks for the PR. Just need to fix some failing tests. Looks like most of them are failing because of the non-standard number characters. |
|
I see. |
Update Japanese translations.
|
Just a few more left, hard to tell what the problem is. Maybe this regex needs to be updated? https://github.com/milesj/emojibase/blob/master/packages/regex/shortcode-native.js#L12 |
Strictly speaking, this definition is insufficient. Also, for the kanji part, a common table is used for Japan, China, and Korea. This area is u2E00 to u9FFF, but also includes uF9xx and uFAxx. The error may be caused by the kanji in this part. It's in Japanese, but for reference, the blue-purple parts of the table on the website below are the CJK kanji. |
|
@logue Sorry, forgot about this. Each time you push changes, can you ping me so I'm aware and I can re-run CI. |
No description provided.