Skip to content

Add missing Japanese translations. - #169

Open
logue wants to merge 4 commits into
milesj:masterfrom
logue:master
Open

Add missing Japanese translations.#169
logue wants to merge 4 commits into
milesj:masterfrom
logue:master

Conversation

@logue

@logue logue commented Mar 29, 2024

Copy link
Copy Markdown

No description provided.

@milesj

milesj commented Mar 29, 2024

Copy link
Copy Markdown
Owner

@logue Thanks for the PR.

Just need to fix some failing tests. Looks like most of them are failing because of the non-standard number characters.

@logue

logue commented Mar 30, 2024

Copy link
Copy Markdown
Author

I see.
Maybe it's because I used full-width numbers.
I'll fix it.

Update Japanese translations.
@milesj

milesj commented Apr 1, 2024

Copy link
Copy Markdown
Owner

Just a few more left, hard to tell what the problem is. Maybe this regex needs to be updated? https://github.com/milesj/emojibase/blob/master/packages/regex/shortcode-native.js#L12

@logue

logue commented Apr 1, 2024

Copy link
Copy Markdown
Author

Just a few more left, hard to tell what the problem is. Maybe this regex needs to be updated? https://github.com/milesj/emojibase/blob/master/packages/regex/shortcode-native.js#L12

Strictly speaking, this definition is insufficient.
For Hiragana, this includes u31xx, which also includes Hangul radicals and Chinese bopomofo.

Also, for the kanji part, a common table is used for Japan, China, and Korea. This area is u2E00 to u9FFF, but also includes uF9xx and uFAxx. The error may be caused by the kanji in this part.

It's in Japanese, but for reference, the blue-purple parts of the table on the website below are the CJK kanji.
https://tools.m-bsys.com/ex/unicode_table.php

@milesj

milesj commented Jun 3, 2024

Copy link
Copy Markdown
Owner

@logue Sorry, forgot about this.

Each time you push changes, can you ping me so I'm aware and I can re-run CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants