MILAB-5720: Add findTableColumn to PFrameWasmAPI

[kevindetry-milaboratories]

Add findTableColumn method to the WASM API interface for looking up table column indices by selector.
Also clarify findAxis returns -1 when not found.

[changeset-bot]

🦋 Changeset detected

Latest commit: 625495d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@milaboratories/pl-model-middle-layer	Minor
@milaboratories/pf-driver	Patch
@milaboratories/pl-middle-layer	Patch
@platforma-sdk/block-tools	Patch
@platforma-sdk/test	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[notion-workspace]

[pframes] Wasm: add findTableColumn method

[gemini-code-assist]

Summary of Changes

Hello @kevindetry-milaboratories, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the WebAssembly (WASM) API by introducing a new utility method for efficiently locating table column indices. It also improves the documentation and clarity of an existing axis-finding method, ensuring consistent error handling. These changes aim to provide more robust and user-friendly programmatic access to data structures within the WASM module.

Highlights

• New API Method: Added a new findTableColumn method to the PFrameWasmAPI interface, allowing lookup of table column indices by selector.
• API Clarity: Clarified the behavior of the existing findAxis method, explicitly stating it returns -1 when no matching axis is found.
• Dependency Update: Updated the pnpm-lock.yaml file to reflect a minor version bump for @milaboratories/pl-model-common.

Changelog

• .changeset/add-find-table-column-to-wasm-api.md
  • Added a new changeset file documenting the addition of the findTableColumn method to PFrameWasmAPI.
• lib/model/middle-layer/src/pframe/internal_api/api_wasm.ts
  • Imported the PTableColumnId type.
  • Added the findTableColumn method to the PFrameWasmAPI interface.
  • Clarified the return value of the findAxis method to explicitly state -1 for not found cases.
• pnpm-lock.yaml
  • Updated the dependency version for @milaboratories/pframes-rs-wasm to reflect the new @milaboratories/pl-model-common version.
  • Updated the @milaboratories/pl-model-common package version from 1.24.11 to 1.25.0.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request successfully adds the findTableColumn method to the PFrameWasmAPI interface, enabling the lookup of table column indices by their identifiers. It also improves the documentation for findAxis by clarifying its return value when no match is found. The changes are consistent with the existing API structure and include the necessary dependency updates. No issues of medium or higher severity were identified.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.63%. Comparing base (01d0b52) to head (625495d).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1450   +/-   ##
=======================================
  Coverage   53.63%   53.63%           
=======================================
  Files         246      246           
  Lines       13662    13662           
  Branches     2812     2812           
=======================================
  Hits         7327     7327           
  Misses       5410     5410           
  Partials      925      925           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.