[BLOCKED] Rolldown + vite 8(rolldown based)#1424
Conversation
|
Summary of ChangesHello @AStaroverov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing the project's build infrastructure by transitioning from Rollup to Rolldown, which aims to improve build performance and maintainability. Concurrently, it refactors core transaction tracking mechanisms to be more explicit and easier to understand, alongside crucial dependency updates and various code quality improvements. The changes collectively enhance the development experience and ensure the codebase remains current with modern tooling standards. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request modernizes the build process by migrating from Rollup to Rolldown, updates dependencies, and refactors transaction tracking in PlTransaction. The changes improve tooling compatibility and code clarity, and include minor bug fixes for SCSS variable usage and type handling. No specific vulnerabilities or critical security issues were found in the provided code changes.
b72bf9f to
3b8613a
Compare
|
blocked by rolldown. don't transform |
This pull request introduces several improvements and refactors across the codebase, focusing on updating build tooling, improving transaction tracking logic, and making minor bug fixes and dependency upgrades. The most impactful changes include replacing the Rollup build system with Rolldown in several places, refactoring the transaction tracking implementation in
PlTransaction, and updating dependencies to newer versions for better compatibility and features.Build System and Tooling Updates:
lib/node/pl-middle-layer,lib/ptabler/schema, andtools/block-tools, updating relevant config files and options (rollupOptions→rolldownOptions). [1] [2] [3] [4]pnpm-workspace.yamlfor improved compatibility and features. [1] [2]typescript.experimental.useTsgosetting in.vscode/settings.jsonto enable experimental TypeScript features.Core Logic Refactoring:
@trackeddecorator and refactored all tracked methods inPlTransactionto explicitly wrap their logic usingthis.track(...), improving clarity and maintainability. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Bug Fixes and Minor Improvements:
PlAutocompleteandPlDropdownLegacycomponents. [1] [2]downloadContentandcalculateSha256. [1] [2]sdk/model/package.jsonto include./render/internalfor better module resolution.tools/block-tools.Other Maintenance:
events-sequence.test.ts.These changes collectively modernize the build process, clarify asynchronous transaction tracking, and resolve minor bugs and type issues throughout the project.