Update to Luanti v5.12.0 #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this setting was removed in #15633
reported at <https://forum.luanti.org/viewtopic.php?p=442729> As it happens this didn't affect most users as jsoncpp allows trailing commas by default since 2019.
The previous fix never did what it was supposed to, so let's do this.
First, this reverts 56123b2, which un-fixes #15031 but fixes #15798 and #15854. Then we disable culling for the cloud scene node which fixes #15031 again.
Instead touch these blocks every 4s.
This also includes a minor bugfix where 'itemstack' was cleared even if the object placement failed.
We can simply add 0x800800800 to the encoding, then use bit masking. This works because adding 0x800 maps -2048:2047 to 0x000:0xFFF. And 0x800800800 is (0x800 << 24 + 0x800 << 12 + 0x800) for x,y,z. After bitmasking, -0x800 restores the original value range.
The error was caused by fd85737, where 'MenuQuit' was processed after 'try_quit'. This commit fixes the error by moving the special 'MenuQuit' handling to Lua.
Second try after the revert in 8a28339 due to an unexpected regression. - Rigidly animated models (e.g. the glTF frog node) were not working correctly, since cloning the mesh ignored the transformation matrices. Note that scaling the mesh needs to occur *after* transforming the vertices. - Visual scale did not apply to skinned models, as resetting the animation overwrote scaled vertex data with static positions & normals. For backwards compatibility, we now apply a 10x scale to static, non-glTF models. We now do scale static meshes, as the bug that caused meshes not to be scaled was limited to skeletally animated meshes, hence we ought not to reproduce it for skinned meshes that do not take advantage of skeletal animations (e.g. current MTG doors). However, glTF models (e.g. Wuzzy's eyeballs) up until recently were always affected due to technical reasons (using skeletal animation for rigid animation). Thus, to preserve behavior, we: 1. Do not apply 10x scale to glTF models. 2. Apply 10x scale to obj models. 3. Apply 10x scale to static x or b3d models, but not to animated ones. See also: #16141
Currently translated at 99.8% (1528 of 1531 strings)
Currently translated at 76.0% (1164 of 1531 strings)
Currently translated at 100.0% (1531 of 1531 strings)
Currently translated at 88.7% (1358 of 1531 strings)
Currently translated at 100.0% (1531 of 1531 strings)
Currently translated at 80.6% (1235 of 1531 strings)
Currently translated at 100.0% (1531 of 1531 strings)
Currently translated at 21.0% (323 of 1531 strings)
This was referenced Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Craftium's modified Luanti engine to the latest Luanti version v5.12.0. The PR also fixes some issues, mainly:
Finally, the PR also includes minor changes as updating some Python dependencies.