Open
Conversation
Collaborator
|
Nice :) Two thoughts:
Edit: And maybe we should even not parse named colors? It might prevent people from producing invalid meta data and thinking it's OK... |
9a79a4a to
41ac4c3
Compare
this is done through the `presentation` sigmf extensions simple, annotation by annotation color setting mechanism Signed-off-by: Jacob Gilbert <jacobgilbert@protonmail.com>
41ac4c3 to
1d976fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an update to #195 that provides essentially the same features through the much more sane
presentation.sigmf-ext.mdwhich can be found in this proposal to upstream it.Example thus becomes:
The use of named colors is not technically supported by the extension, however any valid QColor string will work here.