Easier navigation between datapoints #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manrajgrover
reviewed
Jul 8, 2020
Contributor
manrajgrover
left a comment
manrajgrover
left a comment
There was a problem hiding this comment.
You're on right track, however, I'm unable to test this locally due to missing code. Let me know once this PR is ready.
Contributor
Author
|
You can check the changes. The feature works and I tested for most cases. |
Contributor
Author
|
@manrajgrover The feature is good to go now. Review and let me know if any changes are required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have implemented the navigation feature. The navigation uses a new API that I implemented, which returns the
dataIdfor the previous and next annotation.TODO:
Iconsfor the new buttons added.window.location.reload();upon new page redirect. # I added this as I had some doubts regarding: this.props.history.push(path);