This repository was archived by the owner on Apr 18, 2023. It is now read-only.
Changed visibility of BaseModels files that are mentioned in umbrella header. #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some files that were included in the umbrella had their visibility set to project.
|
|
samdeane
changed the title
|
Note that Xcode seems to have produced a really enormous diff here, but in fact I only modified the visibility of 6 header files. It might be worth re-applying the changes instead of merging this PR. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GraphTutorial project works ok because it uses cocoapods to build, and that includes all of the header files in the framework.
If you just use the xcode project as a dependency though, without cocoapods, the resulting framework does not include some of files that are included in the umbrella header.