Skip to content

Migrate test_bindgen / tool_bindgen into test_fixtures#4373

Merged
kennykerr merged 7 commits intomasterfrom
copilot/refactor-test-bindgen-tool-bindgen
May 4, 2026
Merged

Migrate test_bindgen / tool_bindgen into test_fixtures#4373
kennykerr merged 7 commits intomasterfrom
copilot/refactor-test-bindgen-tool-bindgen

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 4, 2026

  • Migrate tool_bindgen invocations (107) to data/bindgen/<name>/ fixtures
  • Migrate panic.rs cases (28 → 26 fixtures) to data/error/bindgen_<name>/
  • Slim test_bindgen to runtime tests + 5 generated modules they import
  • Delete crates/tools/bindgen/ and crates/tests/libs/bindgen/tests/panic.rs
  • Update data/README.md
  • CI fix: drop tool_bindgen from gen.yml matrix; add target=cfg(windows) deps; trailing-blank-line fmt fix
  • CI fix: change compile_fixtures.rs to #[path = "..."] mod x; so goldens' inner #![allow(...)] is accepted
  • CI fix: skip test_fixtures on the 32-bit i686-pc-windows-msvc job (~110 bindgen fixtures × default winmd exhaust the 2 GB user address space; throttling threads via RUST_TEST_THREADS was unreliable)

…ndgen goldens; fmt

Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/3d4a3687-14aa-4d74-821d-166d20304932

Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
… (allow inner attrs)

Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/8a131966-fc8c-494c-a451-4ab527f00cce

Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
…ed on other targets)

Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/ac18372a-4801-4645-9f25-5c80d1925601

Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
@kennykerr kennykerr merged commit 3ef673f into master May 4, 2026
29 checks passed
@kennykerr kennykerr deleted the copilot/refactor-test-bindgen-tool-bindgen branch May 4, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants