-
Notifications
You must be signed in to change notification settings - Fork 607
rdl reader: drop TypeAttributes::Public for ExclusiveTo interfaces #4162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b9fbcff
rdl reader: omit TypeAttributes::Public for ExclusiveTo interfaces
Copilot bfe55ee
rdl reader: verify full Windows::Foundation::Metadata::ExclusiveTo path
Copilot addfdec
rdl reader: detect ExclusiveTo via find_attribute_type to handle use …
Copilot 6de68a5
rdl: add proper use-declaration test for ExclusiveTo attribute detection
Copilot 627f826
Merge branch 'master' into copilot/compare-metadata-roundtrip-rdl
kennykerr 8d61cb6
rdl test: use input_str + windows-metadata reader to verify Exclusive…
Copilot 95590b5
fmt: fix import ordering in use-declarations.rs
Copilot bad108a
regen: update checked-in winmd files for ExclusiveTo non-public change
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| #[winrt] | ||
| mod Test { | ||
| class Foo {} | ||
| #[Windows::Foundation::Metadata::ExclusiveTo(Foo)] | ||
| interface IFoo {} | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot the only thing this needs to be testing is that the resulting
TypeDefin the winmd is not public.reader().input_str("class ... interface ... ") ...to write a winmd with an exclusive interface.windows-metadatareader to check the interfaceTypeAttributes::Publicflag is present on the class but not present on the interface.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 8d61cb6. The test now:
reader().input_str(...)withuse Windows::Foundation::Metadata::*+#[ExclusiveTo(Foo)]windows_metadata::reader::TypeIndexand assertsFoohasTypeAttributes::PublicwhileIFoodoes not.