Skip to content

Add DelegateFn to pass closures directly as delegate parameters#4157

Draft
Copilot wants to merge 5 commits intomasterfrom
copilot/implement-delegates-as-functions
Draft

Add DelegateFn to pass closures directly as delegate parameters#4157
Copilot wants to merge 5 commits intomasterfrom
copilot/implement-delegates-as-functions

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 7, 2026

  • Understand the problem: CI detected component bindings need regeneration to add From<DelegateFn<F>> impl
  • Revert #![cfg(windows)] from windows-future/src/lib.rs (not part of this PR's scope)
  • Add missing From<DelegateFn<F>> for Callback impl to crates/tests/misc/component/src/bindings.rs
  • Add same impl to crates/tests/misc/component_client/src/bindings.rs
  • Verify build is clean (Linux failures in windows-future are pre-existing - the crate always had Windows-only IMarshal code in its generated bindings)

Copilot AI changed the title Add DelegateFn<F> to pass closures directly as delegate parameters Add DelegateFn to pass closures directly as delegate parameters Apr 7, 2026
Copilot AI requested a review from kennykerr April 7, 2026 20:27
@kennykerr
Copy link
Copy Markdown
Collaborator

@copilot fix the build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants