-
Notifications
You must be signed in to change notification settings - Fork 108
test: update nightly macro expansion tests #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates nightly macro expansion tests to reflect changes in how the Rust nightly compiler expands macros, along with related dependency and configuration updates.
- Updated macro expansion test outputs to match current nightly compiler formatting
- Bumped
wdk-builddependency version from 0.4.0 to 0.5.1 - Added customized-config-toml-workspace to VS Code rust-analyzer configuration
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/wdk-macros-tests/tests/outputs/nightly/macrotest/wdf_driver_create.expanded.rs | Updated expanded macro output with trailing comma to match nightly compiler formatting |
| tests/wdk-macros-tests/tests/outputs/nightly/macrotest/bug_unused_imports.expanded.rs | Updated expanded macro output with trailing comma to match nightly compiler formatting |
| tests/customized-config-toml-workspace/Cargo.lock | Updated wdk-build dependency version to 0.5.1 |
| .vscode/settings.json | Added customized-config-toml-workspace to rust-analyzer linked projects |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
93518c5 to
77e947b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
de4409c to
08ba4e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - name: Run Cargo Test (Top-Level tests Folder via Cargo Make) w/ Nightly Features | ||
| # some tests have varying collateral depending on whether the nightly feature is enabled (not to be confused with the nightly toolchain) | ||
| run: cargo +${{ matrix.rust_toolchain }} make --cwd ./tests test --locked --profile ${{ matrix.cargo_profile }} --features nightly |
Copilot
AI
Nov 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing whitespace detected at the end of this line. Please remove it to maintain code cleanliness.
| run: cargo +${{ matrix.rust_toolchain }} make --cwd ./tests test --locked --profile ${{ matrix.cargo_profile }} --features nightly | |
| run: cargo +${{ matrix.rust_toolchain }} make --cwd ./tests test --locked --profile ${{ matrix.cargo_profile }} --features nightly |
No description provided.