Skip to content

Conversation

@wmmc88
Copy link
Collaborator

@wmmc88 wmmc88 commented Nov 24, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 24, 2025 19:26
Copilot finished reviewing on behalf of wmmc88 November 24, 2025 19:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates nightly macro expansion tests to reflect changes in how the Rust nightly compiler expands macros, along with related dependency and configuration updates.

  • Updated macro expansion test outputs to match current nightly compiler formatting
  • Bumped wdk-build dependency version from 0.4.0 to 0.5.1
  • Added customized-config-toml-workspace to VS Code rust-analyzer configuration

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
tests/wdk-macros-tests/tests/outputs/nightly/macrotest/wdf_driver_create.expanded.rs Updated expanded macro output with trailing comma to match nightly compiler formatting
tests/wdk-macros-tests/tests/outputs/nightly/macrotest/bug_unused_imports.expanded.rs Updated expanded macro output with trailing comma to match nightly compiler formatting
tests/customized-config-toml-workspace/Cargo.lock Updated wdk-build dependency version to 0.5.1
.vscode/settings.json Added customized-config-toml-workspace to rust-analyzer linked projects

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wmmc88 wmmc88 force-pushed the fix-nightly-macrotests branch from 93518c5 to 77e947b Compare November 24, 2025 20:29
Copilot AI review requested due to automatic review settings November 24, 2025 20:51
Copilot finished reviewing on behalf of wmmc88 November 24, 2025 20:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wmmc88 wmmc88 force-pushed the fix-nightly-macrotests branch 2 times, most recently from de4409c to 08ba4e8 Compare November 25, 2025 05:00
Copilot AI review requested due to automatic review settings November 25, 2025 05:00
Copilot finished reviewing on behalf of wmmc88 November 25, 2025 05:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


- name: Run Cargo Test (Top-Level tests Folder via Cargo Make) w/ Nightly Features
# some tests have varying collateral depending on whether the nightly feature is enabled (not to be confused with the nightly toolchain)
run: cargo +${{ matrix.rust_toolchain }} make --cwd ./tests test --locked --profile ${{ matrix.cargo_profile }} --features nightly
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected at the end of this line. Please remove it to maintain code cleanliness.

Suggested change
run: cargo +${{ matrix.rust_toolchain }} make --cwd ./tests test --locked --profile ${{ matrix.cargo_profile }} --features nightly
run: cargo +${{ matrix.rust_toolchain }} make --cwd ./tests test --locked --profile ${{ matrix.cargo_profile }} --features nightly

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant